New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples need to be updated to Cadence 1.0 #782

Open

turbolent opened this issue Oct 17, 2024 · 1 comment

Assignees

Member

turbolent commented Oct 17, 2024

Problem

Some of the examples are still written in pre-Cadence 1.0 and need to be updated.

Steps to Reproduce

For example, open the verify_signature/user_signature example
See pre-1.0 keywords like pub:

flow-go-sdk/examples/verify_signature/user_signature/main.go

Line 43 in 7eb6328

pub fun main(
See missing domainSeparationTag argument:

flow-go-sdk/examples/verify_signature/user_signature/main.go

Lines 84 to 87 in 7eb6328

return keyList.verify(

signatureSet: signatureSet,

signedData: message,

)

Acceptance Criteria

All examples are Cadence 1.0 compatible.

cc @onflow/flow-develop-experience-tools

The text was updated successfully, but these errors were encountered:

nvdtf self-assigned this

Member

nvdtf commented Oct 17, 2024

Good catch! I'll update them.
Thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment