Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we use GetTransactionRequest properly #771

Closed
illia-malachyn opened this issue Sep 24, 2024 · 1 comment
Closed

Make sure we use GetTransactionRequest properly #771

illia-malachyn opened this issue Sep 24, 2024 · 1 comment

Comments

@illia-malachyn
Copy link
Contributor

illia-malachyn commented Sep 24, 2024 •
edited
Loading

This is a part of #736

GetTransactionRequest protobuf message was updated with new fields
https://github.com/onflow/flow/blob/master/protobuf/flow/access/access.proto#L374

We don't use them on the SDK side
https://github.com/onflow/flow-go-sdk/blob/master/access/grpc/grpc.go#L348
@lealobanov lealobanov mentioned this issue Oct 4, 2024
Open
@peterargue
Copy link
Contributor

We're going to skip this work for now since ti will require a breaking change to the API and have not received any requests to add it

@peterargue peterargue closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterargue @illia-malachyn