Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetNodeVersionInfo response object #761

Closed
illia-malachyn opened this issue Sep 19, 2024 · 0 comments · Fixed by #773
Closed

Update GetNodeVersionInfo response object #761

illia-malachyn opened this issue Sep 19, 2024 · 0 comments · Fixed by #773
Assignees

Comments

@illia-malachyn
Copy link
Contributor

This is part of #736.

Align the response object we have in the protobuf schema with what we return in flow-go-sdk

The object we return on flow-go-sdk side:
https://github.com/onflow/flow-go-sdk/blob/master/access/grpc/grpc.go#L174

Protobuf schema:
https://github.com/onflow/flow/blob/master/protobuf/flow/entities/node_version_info.proto#L32

Difference: 1 fields is missing.

// The compatible version range.
CompatibleRange compatible_range = 7;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant