[Indexer] Add index storage interfaces and base in-memory implementation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 29, 2024 16:24
[Indexer] Decoding of event values
ramtinms
reviewed
Feb 6, 2024
ramtinms
approved these changes
Feb 6, 2024
peterargue
approved these changes
Feb 14, 2024
| // Retrieve the block using the blockHeightsIDs map | ||
| blockID, exists := s.base.blockHeightsIDs[height] | ||
| if !exists { | ||
| return nil, errors.NotFound |
There was a problem hiding this comment.
this would indicate an inconsistent state. log an error?
| // Retrieve the block using the blocksIDs map | ||
| block, exists := s.base.blocksIDs[blockID] | ||
| if !exists { | ||
| return nil, errors.NotFound |
| s.base.firstHeight = block.Height | ||
| } | ||
| if s.base.lastHeight == unknownHeight || block.Height > s.base.lastHeight { | ||
| s.base.lastHeight = block.Height |
There was a problem hiding this comment.
does it matter if blocks are store sequentially?
storage/memory/storage.go
Outdated
| r.base.receiptBlockIDTxIDs[receipt.BlockHash] = receipt.TxHash | ||
|
|
||
| if _, ok := r.base.bloomHeight[receipt.BlockNumber.Int64()]; ok { | ||
| return errors.Duplicate |
There was a problem hiding this comment.
I think this would mean that there were 2 receipts with the same ID but different BlockNumber. That seems like an inconsistent state
|
|
||
| receipt, exists := r.base.receiptsTxIDs[txID] | ||
| if !exists { | ||
| return nil, errors.NotFound |
There was a problem hiding this comment.
this would indicate an inconsistent state. log an error?
storage/memory/storage.go
Outdated
| r.base.mu.RLock() | ||
| defer r.base.mu.RUnlock() | ||
|
|
||
| if start.Cmp(end) > -1 { |
There was a problem hiding this comment.
nit
Suggested change
| if start.Cmp(end) > -1 { | |
| if start.Cmp(end) >= 0 { |
[Indexer] Decoding of event values
…ndexer-dec Revert "[Indexer] Decoding of event values"
[Indexer] Implement log providers and filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #17
This is the first part of the PRs that will implement persistent storage. An interfaces have been defined for the indexers as well as a simple in-memory implementation that satisfies the definitions. A simple test suite has been added that validates expected and defined behaviour of the interface implementations.
For contributor use:
masterbranchFiles changedin the Github PR explorer