[Indexer] Implement log providers and filters #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
January 30, 2024 15:46
sideninja
changed the base branch from
gregor/index/storage-base
to
gregor/index/storage-index
added 10 commits
January 31, 2024 15:20
m-Peter
reviewed
Feb 1, 2024
m-Peter
reviewed
Feb 1, 2024
m-Peter
approved these changes
Feb 1, 2024
[Indexer] Decoding of event values
sideninja
commented
Feb 7, 2024
m-Peter
reviewed
Feb 13, 2024
| gethTypes "github.com/ethereum/go-ethereum/core/types" | ||
| "github.com/onflow/flow-evm-gateway/storage" | ||
| "math/big" | ||
| "slices" |
There was a problem hiding this comment.
Suggested change
| "slices" | |
| "golang.org/x/exp/slices" |
peterargue
approved these changes
Feb 14, 2024
Comment on lines
+4
to
+8
| "fmt" | ||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/onflow/cadence" | ||
| cdcCommon "github.com/onflow/cadence/runtime/common" | ||
| "github.com/onflow/flow-go/fvm/evm/types" |
There was a problem hiding this comment.
nit: split stdlib and external imports (here and elsewhere)
Suggested change
| "fmt" | |
| "github.com/ethereum/go-ethereum/common" | |
| "github.com/onflow/cadence" | |
| cdcCommon "github.com/onflow/cadence/runtime/common" | |
| "github.com/onflow/flow-go/fvm/evm/types" | |
| "fmt" | |
| "github.com/ethereum/go-ethereum/common" | |
| "github.com/onflow/cadence" | |
| cdcCommon "github.com/onflow/cadence/runtime/common" | |
| "github.com/onflow/flow-go/fvm/evm/types" |
| } | ||
|
|
||
| receipt := &gethTypes.Receipt{ | ||
| Type: 0, // todo check |
There was a problem hiding this comment.
were you planning to address these todos in this PR or a future one? is there an issue tracking them?
services/logs/filter.go
Outdated
| } | ||
| } | ||
|
|
||
| func (s *StreamFilter) Match() (chan *gethTypes.Log, error) { |
There was a problem hiding this comment.
best to only return the channel receiver, otherwise it could be written to or closed
Suggested change
| func (s *StreamFilter) Match() (chan *gethTypes.Log, error) { | |
| func (s *StreamFilter) Match() (<-chan *gethTypes.Log, error) { |
services/logs/filter.go
Outdated
| defer close(logs) | ||
|
|
||
| for { | ||
| select { |
There was a problem hiding this comment.
you don't need this select since there's only one condition
|
|
||
| // exactMatch checks the topic and address values of the log match the filer exactly. | ||
| func exactMatch(log *gethTypes.Log, criteria FilterCriteria) bool { | ||
| if len(criteria.Topics) > len(log.Topics) { |
There was a problem hiding this comment.
should this be?
Suggested change
| if len(criteria.Topics) > len(log.Topics) { | |
| if len(criteria.Topics) != len(log.Topics) { |
There was a problem hiding this comment.
It shouldn't because the criteria can have less topics than the log, in case where topics are wildcards.
[Indexer] Decoding of event values
…ndexer-dec Revert "[Indexer] Decoding of event values"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #28
Description
This PR implements logs filters. This will be used to implement log filtering based on addresses and topics and will allow for multiple sources either logs indexed in the storage and being queried by block height range, or by subscribing to new stream of logs directly from the network.
There are three log filters:
All the filters reuse the same filter criteria which defines the Addresses and Topics.
The filters are fetched from two different sources:
Providers use bloom filters to determine if a log is relevant or not in order to optimize loading all the data.
The implementation follows the design:
For contributor use:
masterbranchFiles changedin the Github PR explorer