Implement the eth_sendRawTransaction JSON-RPC endpoint
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-Peter
force-pushed
the
eth-send-raw-transaction-endpoint
branch
from
414228a to
fb99ac8
Compare
m-Peter
force-pushed
the
eth-send-raw-transaction-endpoint
branch
from
fb99ac8 to
6f97c77
Compare
sideninja
reviewed
Jan 31, 2024
| return common.Hash{}, err | ||
| } | ||
|
|
||
| privateKey, err := sdkCrypto.DecodePrivateKeyHex(sdkCrypto.ECDSA_P256, strings.Replace("2619878f0e2ff438d17835c2a4561cb87b4d24d72d12ec34569acd0dd4af7c21", "0x", "", 1)) |
There was a problem hiding this comment.
can you get this from ENV configuration
There was a problem hiding this comment.
I am planning to add a flow.json config file, to hold the account and private key that will be used for the gateway. Though I didn't get to it in this PR, to avoid cluttering things. Should we add it here?
There was a problem hiding this comment.
I see. Just add a todo then maybe.
There was a problem hiding this comment.
Sure thing 👍 I also want to add the networks in there, where the indexer will connect to. And we'll see what other config makes sense to have in there.
There was a problem hiding this comment.
Added comments in 4ad8061
sideninja
reviewed
Jan 31, 2024
| return common.Hash{}, err | ||
| } | ||
|
|
||
| account, err := api.FlowClient.GetAccount(context.Background(), flow.HexToAddress("0xf8d6e0586b0a20c7")) |
sideninja
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2
Description
Functionality to send raw EVM transactions.
For contributor use:
masterbranchFiles changedin the Github PR explorer