Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace automatic core contract resolution in FLIX with errors #1853

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Dec 4, 2024

closes: #1837

Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, lgtm

@jribbink jribbink changed the title Replace automatic core contract resolution in FLIX with errors Update Flixkit & Add Error Message for Missing Dependencies Dec 5, 2024
@jribbink jribbink changed the base branch from flixkit-deps-update to master December 5, 2024 22:27
@jribbink jribbink changed the base branch from master to flixkit-deps-update December 6, 2024 00:26
@jribbink jribbink changed the title Update Flixkit & Add Error Message for Missing Dependencies Replace automatic core contract resolution in FLIX with errors Dec 6, 2024
@jribbink jribbink merged commit 8234adb into flixkit-deps-update Dec 6, 2024
7 checks passed
@jribbink jribbink deleted the jribbink/add-validation branch December 6, 2024 00:26
jribbink added a commit that referenced this pull request Dec 6, 2024
* update to use latest version of flixkit-go, pass in core contracts as dependencies

* fix lint issue

* add example in usage, add abstraction for getting core contracts

* add user's dependencies from flow.json as deps for generating flix

* Replace automatic core contract resolution from `flow flix generate` with dependency manager prompts (#1853)

* fix tests

* fix test

* format

---------

Co-authored-by: Jordan Ribbink <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants