Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flixkit & Add Error Message for Missing Dependencies #1852

Merged
merged 9 commits into from
Dec 6, 2024

Conversation

bthaile
Copy link
Contributor

@bthaile bthaile commented Dec 3, 2024

… dependencies

Closes #1424

Description

Update to use latest version of flixkit-go that does not have a dependency on flowkit.
Update to include core contracts allow with user defined contracts when generating a flix template.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

internal/super/flix.go Outdated Show resolved Hide resolved
internal/super/flix.go Outdated Show resolved Hide resolved
internal/super/flix.go Outdated Show resolved Hide resolved
internal/super/flix.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 27 lines in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (308f7f1) to head (ba7b9bb).

Files with missing lines Patch % Lines
internal/super/flix.go 62.96% 12 Missing and 8 partials ⚠️
internal/util/util.go 61.53% 5 Missing ⚠️
internal/dependencymanager/dependencyinstaller.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   27.90%   28.55%   +0.64%     
==========================================
  Files          95       95              
  Lines        6482     6524      +42     
==========================================
+ Hits         1809     1863      +54     
+ Misses       4497     4479      -18     
- Partials      176      182       +6     
Flag Coverage Δ
unittests 28.55% <60.86%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/super/flix.go Outdated Show resolved Hide resolved
internal/super/flix.go Outdated Show resolved Hide resolved
@bthaile
Copy link
Contributor Author

bthaile commented Dec 5, 2024

closing, these changes get picked up on another PR

@bthaile bthaile closed this Dec 5, 2024
@jribbink jribbink reopened this Dec 6, 2024
@jribbink jribbink changed the title update to use latest version of flixkit-go, pass in core contracts as… Update Flixkit & Add Error Message for Missing Dependencies Dec 6, 2024
@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Dec 6, 2024
@jribbink jribbink merged commit 8b1c89e into master Dec 6, 2024
5 checks passed
@jribbink jribbink deleted the flixkit-deps-update branch December 6, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants