-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Flixkit & Add Error Message for Missing Dependencies #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthaile
requested review from
Kay-Zee,
janezpodhostnik,
chasefleming,
nvdtf,
bluesign,
bjartek and
jribbink
as code owners
December 3, 2024 17:29
nvdtf
approved these changes
Dec 3, 2024
chasefleming
requested changes
Dec 3, 2024
chasefleming
requested changes
Dec 3, 2024
chasefleming
requested changes
Dec 3, 2024
chasefleming
requested changes
Dec 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1852 +/- ##
==========================================
+ Coverage 27.90% 28.55% +0.64%
==========================================
Files 95 95
Lines 6482 6524 +42
==========================================
+ Hits 1809 1863 +54
+ Misses 4497 4479 -18
- Partials 176 182 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chasefleming
requested changes
Dec 3, 2024
chasefleming
requested changes
Dec 4, 2024
closing, these changes get picked up on another PR |
…with dependency manager prompts (#1853)
jribbink
approved these changes
Dec 6, 2024
jribbink
changed the title
update to use latest version of flixkit-go, pass in core contracts as…
Update Flixkit & Add Error Message for Missing Dependencies
Dec 6, 2024
chasefleming
approved these changes
Dec 6, 2024
jribbink
added
the
Improvement
Technical work without new features, refactoring, improving tests
label
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… dependencies
Closes #1424
Description
Update to use latest version of flixkit-go that does not have a dependency on flowkit.
Update to include core contracts allow with user defined contracts when generating a flix template.
For contributor use:
master
branchFiles changed
in the Github PR explorer