Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include EVM stdlib in staging update validator #1697

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Aug 14, 2024

Closes #1693

Description

Adds the EVM stdlib to staging update validator


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink marked this pull request as draft August 14, 2024 22:20
@jribbink jribbink marked this pull request as ready for review August 14, 2024 22:26
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 36.11111% with 92 lines in your changes missing coverage. Please review.

Project coverage is 34.18%. Comparing base (819f8bc) to head (74d52d5).

Files Patch % Lines
internal/util/checker_environment.go 28.57% 89 Missing and 1 partial ⚠️
internal/migrate/staging_validator.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
+ Coverage   33.90%   34.18%   +0.28%     
==========================================
  Files         100      100              
  Lines        6256     6307      +51     
==========================================
+ Hits         2121     2156      +35     
- Misses       3851     3865      +14     
- Partials      284      286       +2     
Flag Coverage Δ
unittests 34.18% <36.11%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nvdtf nvdtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏

@jribbink jribbink merged commit 5d187a5 into master Aug 15, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/internal-evm branch August 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore EVM errors when staging contracts
5 participants