Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user if missing flag args on create account #1668

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

chasefleming
Copy link
Member

Closes #1658

Description

Manual mode requires a key. Warn a user if they are missing the key flag before switching to interactive mode.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.97%. Comparing base (9d41db9) to head (72a6b86).

Files Patch % Lines
internal/accounts/create.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
- Coverage   33.97%   33.97%   -0.01%     
==========================================
  Files         100      100              
  Lines        6248     6251       +3     
==========================================
+ Hits         2123     2124       +1     
- Misses       3841     3844       +3     
+ Partials      284      283       -1     
Flag Coverage Δ
unittests 33.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit 8f4556c into master Jul 3, 2024
5 checks passed
@chasefleming chasefleming deleted the chasefleming/warn-on-flags branch July 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"flow accounts create", flags is not working
3 participants