Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contract/dependencies conflict checker #1600

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented May 15, 2024

Closes #1599


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming added the Bug The issue represents a bug, malfunction, regression label May 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 39.61%. Comparing base (9d33723) to head (85cc0c2).

Files Patch % Lines
internal/dependencymanager/dependencyinstaller.go 23.07% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
- Coverage   39.95%   39.61%   -0.35%     
==========================================
  Files          51       51              
  Lines        3346     3345       -1     
==========================================
- Hits         1337     1325      -12     
- Misses       1841     1851      +10     
- Partials      168      169       +1     
Flag Coverage Δ
unittests 39.61% <23.07%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit f1014f3 into master May 16, 2024
8 checks passed
@chasefleming chasefleming deleted the cf/fix-contract-check branch May 16, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue represents a bug, malfunction, regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix dependencies/contracts conflict check
3 participants