Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message if conflicting contract on dependency install #1561

Merged
merged 1 commit into from
May 2, 2024

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented May 2, 2024

Closes #1560


Screenshot 2024-05-02 at 1 54 29 PM

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming added the Feature A new user feature or a new package API label May 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 41.37931% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 39.66%. Comparing base (3b93072) to head (0c72153).

Files Patch % Lines
internal/dependencymanager/dependencyinstaller.go 41.37% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
- Coverage   39.71%   39.66%   -0.06%     
==========================================
  Files          51       51              
  Lines        3278     3300      +22     
==========================================
+ Hits         1302     1309       +7     
- Misses       1814     1826      +12     
- Partials      162      165       +3     
Flag Coverage Δ
unittests 39.66% <41.37%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice 🤘🏼

@chasefleming chasefleming merged commit 4633ff0 into master May 2, 2024
11 checks passed
@chasefleming chasefleming deleted the chaseflmeing/1560 branch May 2, 2024 22:41
Copy link

sentry-io bot commented May 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message if conflicting contract on dependency install
4 participants