Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for latest Cadence 1.0 release #1496

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Apr 5, 2024

Closes #1411

Description

Adds a check for latest cadence 1.0 release. We should remove this when feature/stable-cadence is merged into master, but if this is forgotten about, it shouldn't cause any issues either.

It's probably a good idea to have this so developers don't run into resolved issues since it's hard to track latest CLI versions/if you're using outdated CLI.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Apr 5, 2024
@jribbink jribbink changed the base branch from master to feature/stable-cadence April 5, 2024 15:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 41.62%. Comparing base (5c0fa11) to head (f59ae21).

❗ Current head f59ae21 differs from pull request most recent head c83c5bf. Consider uploading reports for the commit c83c5bf to get more accurate results

Files Patch % Lines
internal/command/command.go 0.00% 34 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #1496      +/-   ##
==========================================================
- Coverage                   41.99%   41.62%   -0.38%     
==========================================================
  Files                          59       59              
  Lines                        3360     3390      +30     
==========================================================
  Hits                         1411     1411              
- Misses                       1745     1775      +30     
  Partials                      204      204              
Flag Coverage Δ
unittests 41.62% <0.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit b43b650 into feature/stable-cadence Apr 5, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/c1-vsn-check branch April 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user message when newer version of Cadence 1.0 CLI is available
3 participants