You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When trying to stage contracts, sometimes I get errors that a contract is not staged but it is. @bjartek has hit this problem as well for a contract that we at Flowty own and know we had staged
Steps to Reproduce
Have a contract to stage with many depdendencies
Stage the contract
Example:
@bjartek tried to stage some of Find's contracts and got the following:
These contracts depend on the following contracts which have not been staged yet:
- 473d6a2c37eab5be.LostAndFound
- 473d6a2c37eab5be.LostAndFoundHelper
- e544175ee0461c4b.TokenForwarding
- ead892083b3e2c6c.DapperUtilityCoin
- ec67451f8a58216a.PublicPriceOracle
However, if I try to stage LostAndFound, it is already done:
lost-and-found git:(main) flow-c1 migrate stage --network mainnet
✔ 473d6a2c37eab5be.LostAndFound (no changes)
✔ 473d6a2c37eab5be.FeeEstimator (no changes)
✔ 473d6a2c37eab5be.LostAndFoundHelper (no changes)
We suspect it has to do with rate limiting against flow's public access nodes which is 5 QPS. If you have many dependencies, you will quickly meet that limit, and a throttled dependency check is treated as a contract not being staged
Acceptance Criteria
Dependency stage status check should be batched
Context
Some bigger contracts fail to be staged because it thinks that dependencies are not migrated
The text was updated successfully, but these errors were encountered:
Problem
When trying to stage contracts, sometimes I get errors that a contract is not staged but it is. @bjartek has hit this problem as well for a contract that we at Flowty own and know we had staged
Steps to Reproduce
Example:
@bjartek tried to stage some of Find's contracts and got the following:
However, if I try to stage LostAndFound, it is already done:
We suspect it has to do with rate limiting against flow's public access nodes which is 5 QPS. If you have many dependencies, you will quickly meet that limit, and a throttled dependency check is treated as a contract not being staged
Acceptance Criteria
Dependency stage status check should be batched
Context
Some bigger contracts fail to be staged because it thinks that dependencies are not migrated
The text was updated successfully, but these errors were encountered: