Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage command dependency check has non-deterministic results #1703

Closed
austinkline opened this issue Aug 22, 2024 · 1 comment · Fixed by #1706
Closed

Stage command dependency check has non-deterministic results #1703

austinkline opened this issue Aug 22, 2024 · 1 comment · Fixed by #1706
Assignees
Labels
Bug The issue represents a bug, malfunction, regression

Comments

@austinkline
Copy link

austinkline commented Aug 22, 2024

Problem

When trying to stage contracts, sometimes I get errors that a contract is not staged but it is. @bjartek has hit this problem as well for a contract that we at Flowty own and know we had staged

Steps to Reproduce

  1. Have a contract to stage with many depdendencies
  2. Stage the contract

Example:

@bjartek tried to stage some of Find's contracts and got the following:

These contracts depend on the following contracts which have not been staged yet:
  - 473d6a2c37eab5be.LostAndFound
  - 473d6a2c37eab5be.LostAndFoundHelper
  - e544175ee0461c4b.TokenForwarding
  - ead892083b3e2c6c.DapperUtilityCoin
  - ec67451f8a58216a.PublicPriceOracle

However, if I try to stage LostAndFound, it is already done:

lost-and-found git:(main) flow-c1 migrate stage --network mainnet

✔ 473d6a2c37eab5be.LostAndFound  (no changes)
✔ 473d6a2c37eab5be.FeeEstimator  (no changes)
✔ 473d6a2c37eab5be.LostAndFoundHelper  (no changes)

We suspect it has to do with rate limiting against flow's public access nodes which is 5 QPS. If you have many dependencies, you will quickly meet that limit, and a throttled dependency check is treated as a contract not being staged

Acceptance Criteria

Dependency stage status check should be batched

Context

Some bigger contracts fail to be staged because it thinks that dependencies are not migrated

@bjartek
Copy link
Collaborator

bjartek commented Aug 22, 2024

When i use my own AN i only get that these two are missing

- ead892083b3e2c6c.DapperUtilityCoin
- ec67451f8a58216a.PublicPriceOracle

@turbolent turbolent self-assigned this Aug 23, 2024
@turbolent turbolent added the Bug The issue represents a bug, malfunction, regression label Aug 26, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in 🌊 Flow 4D Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue represents a bug, malfunction, regression
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants