Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add isValidated on staging migration #1478

Closed
ianthpun opened this issue Mar 27, 2024 · 0 comments
Closed

add isValidated on staging migration #1478

ianthpun opened this issue Mar 27, 2024 · 0 comments
Assignees
@ianthpun

Comments

@ianthpun
Copy link
Contributor

ianthpun commented Mar 27, 2024 •
edited
Loading

isValidated confirms that the staged contract passed its previous emulated migration which goes through contract validation.

https://github.com/onflow/contract-updater/blob/main/contracts/MigrationContractStaging.cdc#L143-L145

https://github.com/onflow/contract-updater/blob/main/contracts/MigrationContractStaging.cdc#L284-L294

this will be useful for folks to confirm whether this contract update passed the last emulated migration, validating the contained code.
@ianthpun ianthpun self-assigned this Mar 27, 2024
@ianthpun ianthpun converted this from a draft issue Mar 27, 2024
This was referenced Mar 27, 2024
Merged
Closed
@ianthpun ianthpun moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Mar 28, 2024
@gregsantos gregsantos moved this from ✅ Done to Closed (Cycle 2) in 🌊 Flow 4D Mar 29, 2024
@github-project-automation github-project-automation bot moved this from Closed (Cycle 2) to ✅ Done in 🌊 Flow 4D Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianthpun ianthpun

Labels
None yet
Projects
🌊 Flow 4D
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chasefleming @ianthpun