You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An issue/question was recently encountered with the flow migrate state command. It is as follows: what should the behaviour be if the user has configured their flow.json with multiple deployments for the same contract? Currently, all of the migration commands (i.e. flow migrate stage-contract, flow migrate state) only make an assumption that a contract will only be deployed to one account: this is not true.
It is possible that contracts -> deployments is a one to many relationship & not one to one. In the current form, the first match is chosen & subsequent deployments entries will be skipped. However, this behaviour may not be desirable for some.
Steps to Reproduce
Make flow.json with a contract that appears twice in the deployments section, try using these commands.
Acceptance Criteria
There should be some mechanism in place to handle these conflicts. Some options are as follows:
Apply these commands to every account with the contract's name in their deployments. Logically, this makes sense - if you have an updated version of the contract code, why wouldn't you simply want to update/stage the update for all accounts using this contract?
Require more granular specification of accounts when they are ambiguous --> (i.e. require acct1:Contract syntax if many accounts with this deployment exist?)
Problem
An issue/question was recently encountered with the
flow migrate state
command. It is as follows: what should the behaviour be if the user has configured their flow.json with multiple deployments for the same contract? Currently, all of the migration commands (i.e.flow migrate stage-contract
,flow migrate state
) only make an assumption that a contract will only be deployed to one account: this is not true.It is possible that contracts -> deployments is a one to many relationship & not one to one. In the current form, the first match is chosen & subsequent
deployments
entries will be skipped. However, this behaviour may not be desirable for some.Steps to Reproduce
Make
flow.json
with acontract
that appears twice in thedeployments
section, try using these commands.Acceptance Criteria
There should be some mechanism in place to handle these conflicts. Some options are as follows:
acct1:Contract
syntax if many accounts with this deployment exist?)Context
https://discordapp.com/channels/613813861610684416/1123314820763111465/1220759822065078383
The text was updated successfully, but these errors were encountered: