Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow test logs are suppressed #1460

Closed
jribbink opened this issue Mar 18, 2024 · 0 comments · Fixed by #1461
Closed

flow test logs are suppressed #1460

jribbink opened this issue Mar 18, 2024 · 0 comments · Fixed by #1461
Assignees
Labels

Comments

@jribbink
Copy link
Contributor

As of cadence-tools/[email protected], logs are suppressed by default unless a logger is provided. These are useful diagnostics for developers and should be surfaced somehow.

I think the best solution is to output this to stderr, as it is fundamentally a user/diagnostic message, and this way it does not pollute the CLI output (i.e. previous issues have existed with this non-json data going to stdout when --output=json was used)

@jribbink jribbink self-assigned this Mar 18, 2024
@jribbink jribbink moved this to 👀 In Review in 🌊 Flow 4D Mar 18, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Mar 18, 2024
@gregsantos gregsantos moved this from ✅ Done to Closed (Cycle 2) in 🌊 Flow 4D Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant