Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch hardcoded core contracts to come from package #1406

Closed
chasefleming opened this issue Feb 12, 2024 · 1 comment · Fixed by #1466
Closed

Switch hardcoded core contracts to come from package #1406

chasefleming opened this issue Feb 12, 2024 · 1 comment · Fixed by #1466
Assignees
Labels
Improvement Technical work without new features, refactoring, improving tests

Comments

@chasefleming
Copy link
Member

Core contracts are currently hardcoded for the project package here:

func checkForStandardContractUsageOnMainnet(state *flowkit.State, logger output.Logger, replace bool) error {

We should swap this out to use the package now that provides core contracts by network.

@chasefleming chasefleming added the Improvement Technical work without new features, refactoring, improving tests label Feb 12, 2024
@chasefleming chasefleming self-assigned this Feb 12, 2024
@chasefleming chasefleming moved this to 🧊 Backlog in 🌊 Flow 4D Feb 12, 2024
@bthaile
Copy link
Contributor

bthaile commented Feb 16, 2024

Flixkit-go would benefit from having mainnet and testnet core-contract addresses it can easily import.

@ianthpun ianthpun assigned ianthpun and unassigned chasefleming Mar 18, 2024
@chasefleming chasefleming moved this from 🧊 Backlog to 🏗 In Progress in 🌊 Flow 4D Mar 19, 2024
@chasefleming chasefleming moved this from 🏗 In Progress to 👀 In Review in 🌊 Flow 4D Mar 19, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Mar 19, 2024
@gregsantos gregsantos moved this from ✅ Done to Closed (Cycle 2) in 🌊 Flow 4D Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants