Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all code snippets to C1.0 #21

Closed
lealobanov opened this issue Nov 13, 2024 · 3 comments
Closed

Update all code snippets to C1.0 #21

lealobanov opened this issue Nov 13, 2024 · 3 comments
Assignees
@lealobanov

Comments

@lealobanov
Copy link
Collaborator

lealobanov commented Nov 13, 2024 •
edited
Loading

Related PRs:

Follow-up PRs:

Status: End to End Repo CI

Repo PRs Outstanding Issues Status
add-a-play-to-topshot-set onflow/add-a-play-to-topshot-set#1, onflow/add-a-play-to-topshot-set#2 None ✅
add-admin-resource-to-account onflow/add-admin-resource-to-account#1 Resolve source code for SetAndSeries import - seems to be related to https://testnet.flowdiver.io/tx/10dbf12a5ffa4f938f438b4a883fa233c7d0f1470dc55d26c9f2eea4c4fceb4c?tab=events
admin-resource onflow/admin-resource#1 Resolve source code for SetAndSeries import
collection-for-holding-nfts onflow/collection-for-holding-nfts#1 None ✅
create-a-marketplace onflow/create-a-marketplace#1 None ✅
create-a-topshot-play onflow/create-a-topshot-play#1 None ✅
create-a-topshot-set onflow/create-a-topshot-set#1 None ✅
create-an-nft-listing onflow/create-an-nft-listing#1 None
creating-a-set-in-series onflow/creating-a-set-in-series#1 Resolve source code for SetAndSeries import
creating-a-vault onflow/creating-a-vault#1 None ✅
creating-collection-for-account onflow/creating-collection-for-account#1 None
implementing-series-for-nfts onflow/implementing-series-for-nfts#1 Resolve source code for SetAndSeries import
metadata-views onflow/metadata-views#1 None
mint-nft onflow/mint-nft#1 None.
minting-a-moment-in-topshot-set onflow/minting-a-moment-in-topshot-set#1 None
multiple-metadata-views onflow/multiple-metadata-views#1 None
nft-with-metadata onflow/nft-with-metadata#1 None
purchase-nft-on-marketplace onflow/purchase-nft-on-marketplace#1 None
token-vault onflow/token-vault#1 None
vault-minter onflow/vault-minter#1 None
withdrawing-tokens onflow/withdrawing-tokens#1 None
@lealobanov lealobanov self-assigned this Nov 13, 2024
@lealobanov
Copy link
Collaborator Author

lealobanov commented Jan 7, 2025 •
edited
Loading

@franklywatson double checking just to confirm the following:

Recipes involving TopShot which I have unliked from Git submodules of the main repo (will effectively remove them from Cookbook front-end, I suppose we can still keep the repos for now):

SetAndSeries recipes to be re-worked (demonstrating admin resource; I will swap these to use one of the native Flow contracts):

SetAndSeries recipes to be removed:

@lealobanov
Copy link
Collaborator Author

lealobanov commented Jan 14, 2025 •
edited
Loading

Hi @franklywatson, I just ran the release on main. The remaining outstanding PRs below are to remove fields that are no longer used by the front-end end (no impact on visual appearance or logic), apart from that should be all set:

Thanks!

@franklywatson
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lealobanov lealobanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franklywatson @lealobanov