Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPD] l10n_nl_rgs: Updated values for Inkopen - BTW verlegd (21%) tax and added Inkopen - BTW verlegd (9%) tax #43

Merged
merged 2 commits into from
May 2, 2024

Conversation

ByteMeAsap
Copy link
Contributor

No description provided.

@ByteMeAsap
Copy link
Contributor Author

Do we also need to add mappings in fiscal position for 9% tax like for 21%
Screenshot from 2024-04-24 17-18-31

Copy link
Collaborator

@andreschenkels andreschenkels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but as @ByteMeAsap asked. We also need to add the 9% verlegd in the fiscal position mappings.

… and added Inkopen - BTW verlegd (9%) tax

Added New tax in Fiscal position
@ByteMeAsap ByteMeAsap force-pushed the 16.0-rgs-tax_updates branch from bcfd128 to af25523 Compare April 25, 2024 12:41
@ByteMeAsap
Copy link
Contributor Author

This looks good but as @ByteMeAsap asked. We also need to add the 9% verlegd in the fiscal position mappings.

@andreschenkels , Added the 9% verlegd in the fiscal position mappings as well

@ThijsvOers
Copy link

@ByteMeAsap the tax group is not correct for the group BTW verlegd. It is Nul (zero) in the standard, but maybe you can combine this with the other request I had to create a new Tax Group BTW Verlegd (applicable to all the BTW verlegd VAT codes
image

@ByteMeAsap
Copy link
Contributor Author

@ThijsvOers , I have added the tax group, but that would need to manually adjusted on the taxes

@andreschenkels , I have added the migration script, but it will be to add new taxes , update fiscal positions , but only update tags for existing taxes

Copy link

@ThijsvOers ThijsvOers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this and both 21 and 9% VAT reversed charge are now correct

@ByteMeAsap ByteMeAsap requested a review from andreschenkels May 1, 2024 09:02
Copy link
Collaborator

@andreschenkels andreschenkels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can be merged now.

@ByteMeAsap ByteMeAsap merged commit 6fb7b92 into 16.0 May 2, 2024
2 of 3 checks passed
@ByteMeAsap ByteMeAsap deleted the 16.0-rgs-tax_updates branch May 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants