XAF RGS Module #40
Merged
XAF RGS Module #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThijsvOers could you do a test? |
|
@tarteo is it possible to get a new runboat? There is a module website_payment_recurring_donations_mollie giving some pre-commit errors on the website in the manifest file. |
tarteo
force-pushed
the
PR-XAF-Export-with-RGS
branch
from
c198be4 to
76d2849
Compare
|
@ThijsvOers this one has the correct runboat you can review this now. |
ThijsvOers
approved these changes
Apr 29, 2024
tarteo
reviewed
May 7, 2024
|
|
||
| def _get_auditfile_template(self): | ||
| """return the qweb template to be rendered""" | ||
| return "l10n_nl_rgs_xaf_auditfile_export.auditfile_template" |
There was a problem hiding this comment.
If you remove primary="True" from the template (auditfile_template) we don't need this. Correct me if I'm wrong
There was a problem hiding this comment.
@tarteo , you are correct
|
Ignoring automatic tests results. |
|
Hoi @tarteo kun je deze laatste wijziging terugdraaien. Na de laatste wijziging werkt het dus niet meer. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.