Pr journal subtype allowed journals #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarteo
reviewed
Mar 27, 2024
ThijsvOers
reviewed
Apr 4, 2024
There was a problem hiding this comment.
@andreschenkels I can see in the commit that you added the TAX journal to the requested account groups, but I cannot see these in the test environment (neither in the account group nor in the related accounts). Should I create an extra company to see the result?
|
@tarteo could you check the code again? |
ADD Taxes Journal IMP Allowed Journals on Account Group
tarteo
force-pushed
the
PR-JournalSubtype-AllowedJournals
branch
from
5c82b25 to
ea87c81
Compare
|
Approved, ignoring test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADD Account Journal Subtype
ADD Taxes Journal
IMP Allowed Journals on Account Group