Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording for scenario and transaction #19

Open
kevin-delmas opened this issue Oct 28, 2024 · 3 comments
Open

Wording for scenario and transaction #19

kevin-delmas opened this issue Oct 28, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@kevin-delmas
Copy link
Collaborator

The wording used in the code is confusing.
The notion of transaction, atomic transaction and multi-transaction should be preferred over the transaction/scenario wording that is not adatpted.
Considering a full refactoring to only use transaction and multi-transaction

@kevin-delmas kevin-delmas added the enhancement New feature or request label Oct 28, 2024
@kevin-delmas kevin-delmas self-assigned this Oct 28, 2024
@kevin-delmas
Copy link
Collaborator Author

@cpagetti @FredBoniol what do you think of such a refactoring?
Note that, we can do it in two different ways:

  • either we just add the new names and leave the old ones accessible but deprecated
  • or we remove the old ones, beware this will lead to a non retro-compatible version so all users that want to step to the new version need to update their models

@kevin-delmas
Copy link
Collaborator Author

So I propose to implement the refactoring in a dedicated branch. If the changes are satisfactory a new major revision (without retro-compatibility) will be pushed on Sonatype.

@kevin-delmas
Copy link
Collaborator Author

Fred is proposing to keep Scenarios but annote it as deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant