From 4bc568138d9013a6a34da16063b33500f0aaffc1 Mon Sep 17 00:00:00 2001 From: markuczy Date: Fri, 11 Oct 2024 09:45:39 +0200 Subject: [PATCH] fix: remove unnecessary test code and fix helm value --- helm/values.yaml | 2 +- .../column-group-selection.component.spec.ts | 7 ------- .../search-config/search-config.component.spec.ts | 11 +---------- 3 files changed, 2 insertions(+), 18 deletions(-) diff --git a/helm/values.yaml b/helm/values.yaml index c4ec5c0..7716797 100644 --- a/helm/values.yaml +++ b/helm/values.yaml @@ -4,7 +4,7 @@ app: repository: 'onecx/onecx-search-config-ui' routing: enabled: true - path: /mfe/onecxSearchConfig/ + path: /mfe/search-config/ operator: # Microfrontend diff --git a/src/app/remotes/column-group-selection/column-group-selection.component.spec.ts b/src/app/remotes/column-group-selection/column-group-selection.component.spec.ts index 4e4dd62..c0180cd 100644 --- a/src/app/remotes/column-group-selection/column-group-selection.component.spec.ts +++ b/src/app/remotes/column-group-selection/column-group-selection.component.spec.ts @@ -27,7 +27,6 @@ import { PortalDialogService, PortalMessageService, } from '@onecx/portal-integration-angular'; -import { AppConfigService } from '@onecx/angular-integration-interface'; import { Configuration, SearchConfigAPIService, @@ -74,8 +73,6 @@ describe('OneCXColumnGroupSelectionComponent', () => { })), }); - const appConfigSpy = createSpyObj('appConfig', []) as AppConfigService; - const searchConfigServiceSpy = { ...createSpyObj('searchConfigService', [ 'getSearchConfigInfos', @@ -219,10 +216,6 @@ describe('OneCXColumnGroupSelectionComponent', () => { ], providers: [ DialogService, - { - provide: AppConfigService, - useValue: appConfigSpy, - }, { provide: PortalDialogService, useValue: portalDialogSpy, diff --git a/src/app/remotes/search-config/search-config.component.spec.ts b/src/app/remotes/search-config/search-config.component.spec.ts index e7485a5..415ae60 100644 --- a/src/app/remotes/search-config/search-config.component.spec.ts +++ b/src/app/remotes/search-config/search-config.component.spec.ts @@ -9,10 +9,7 @@ import { BASE_URL, RemoteComponentConfig, } from '@onecx/angular-remote-components'; -import { - AppConfigService, - AppStateService, -} from '@onecx/angular-integration-interface'; +import { AppStateService } from '@onecx/angular-integration-interface'; import { CommonModule } from '@angular/common'; import { NO_ERRORS_SCHEMA, NgModule } from '@angular/core'; import { provideHttpClientTesting } from '@angular/common/http/testing'; @@ -76,8 +73,6 @@ describe('OneCXSearchConfigComponent', () => { })), }); - const appConfigSpy = createSpyObj('appConfig', []) as AppConfigService; - const searchConfigServiceSpy = { ...createSpyObj('searchConfigService', [ 'getSearchConfigInfos', @@ -218,10 +213,6 @@ describe('OneCXSearchConfigComponent', () => { ], providers: [ DialogService, - { - provide: AppConfigService, - useValue: appConfigSpy, - }, { provide: PortalDialogService, useValue: portalDialogSpy,