Add detailed documentation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydgreenfield
force-pushed
the
boyd/add-release-docs
branch
2 times, most recently
from
d6bb4ab
to
e748188
Compare
boydgreenfield
changed the title
boydgreenfield
force-pushed
the
boyd/add-release-docs
branch
2 times, most recently
from
fbe3ee7
to
11614dd
Compare
Keats
reviewed
Feb 3, 2023
GSGerritsen
reviewed
Feb 7, 2023
boydgreenfield
force-pushed
the
boyd/add-release-docs
branch
3 times, most recently
from
413506f
to
4e2ac0d
Compare
boydgreenfield
changed the title
|
FYI rebasing this for cleanliness. Commits post your comments @Keats @GSGerritsen are on this branch in case you want to look at them (I'll delete in a few days). Tests pass and this doesn't change any APIs or functionality, so I'm going to merge once cleaned up! |
boydgreenfield
force-pushed
the
boyd/add-release-docs
branch
from
4e2ac0d
to
e1dce7c
Compare
boydgreenfield
force-pushed
the
boyd/add-release-docs
branch
from
e1dce7c
to
96cd358
Compare
|
🤦♂️ I updated our primary branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Keats @GSGerritsen Would love your review here. Note there are a few outstanding items before I want to merge this, including:
I'll then tackle making sure our
cargo docsare consistent in a separate PR (see #13) as well as adding more detailed benchmarking (#15).Closes #12. Closes #14.