Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPC API does not work with the proxy library #864

Open
ldorau opened this issue Nov 5, 2024 · 1 comment · May be fixed by #868
Open

IPC API does not work with the proxy library #864

ldorau opened this issue Nov 5, 2024 · 1 comment · May be fixed by #868
Assignees
@ldorau
Labels
bug Something isn't working

Comments

@ldorau
Copy link
Contributor

ldorau commented Nov 5, 2024 •
edited
Loading

IPC API does not work with the proxy library.
IPC tests: umf-provider_devdax_memory_ipc and umf-provider_file_memory_ipc fail with the proxy library.

The reason: issues with the tracker (ref: #761).

See: https://github.com/oneapi-src/unified-memory-framework/actions/runs/11680149618/job/32522557687
See: https://github.com/ldorau/unified-memory-framework/actions/runs/11681287895/job/32526033443

Ref: #863 (commented out IPC test umf-provider_devdax_memory_ipc)
Ref: #847 (commented out IPC test umf-provider_file_memory_ipc)

Ref: #868
See: https://github.com/oneapi-src/unified-memory-framework/actions/runs/11683497460

Environment Information

  • UMF version (hash commit or a tag): cdc0310
  • OS(es) version(s): Linux

Please provide a reproduction of the bug:

Run the umf-provider_devdax_memory_ipc with the proxy library:
See: https://github.com/oneapi-src/unified-memory-framework/actions/runs/11680149618/job/32522557687

or

run the umf-provider_file_memory_ipc with the proxy library:
See: https://github.com/ldorau/unified-memory-framework/actions/runs/11681287895/job/32526033443

How often bug is revealed:

always
@ldorau ldorau added the bug Something isn't working label Nov 5, 2024
@ldorau ldorau mentioned this issue Nov 5, 2024
Merged
3 tasks
@ldorau
Copy link
Contributor Author

ldorau commented Nov 5, 2024

@vinser52 @bratpiorka @lplewa

ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 5, 2024
@ldorau
Disable the provider_file_memory_ipc test with the proxy library
86b3e58 
Disable the provider_file_memory_ipc test with the proxy library,
because the IPC tests do not work with the proxy library.

Ref: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 5, 2024
@ldorau
Disable the provider_file_memory_ipc test with the proxy library
2ec98b9 
Disable the provider_file_memory_ipc test with the proxy library,
because the IPC tests do not work with the proxy library.

Ref: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
This was referenced Nov 5, 2024
Merged
Draft
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 5, 2024
@ldorau
Disable the provider_file_memory_ipc test with the proxy library
7ab4ef3 
Disable the provider_file_memory_ipc test with the proxy library,
because the IPC tests do not work with the proxy library.

Ref: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau changed the title IPC tests do not work with the proxy library IPC API does not work with the proxy library Nov 5, 2024
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 6, 2024
@ldorau
Disable the provider_file_memory_ipc test with the proxy library
de4e426 
Disable the provider_file_memory_ipc test with the proxy library,
because the IPC tests do not work with the proxy library.

Ref: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 6, 2024
@ldorau
Disable the provider_file_memory_ipc test with the proxy library
347c808 
Disable the provider_file_memory_ipc test with the proxy library,
because the IPC tests do not work with the proxy library.

Ref: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 6, 2024
@ldorau
Disable the provider_file_memory_ipc test with the proxy library
4652e08 
Disable the provider_file_memory_ipc test with the proxy library,
because the IPC tests do not work with the proxy library.

Ref: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau mentioned this issue Nov 6, 2024
Merged
4 tasks
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 6, 2024
@ldorau
Disable the provider_file_memory_ipc test with the proxy library
bf6dc3e 
Disable the provider_file_memory_ipc test with the proxy library,
because the IPC tests do not work with the proxy library.

Ref: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 7, 2024
@ldorau
Disable the provider_file_memory_ipc test with the proxy library
ca5ab59 
Disable the provider_file_memory_ipc test with the proxy library,
because the IPC tests do not work with the proxy library.

Ref: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau self-assigned this Nov 14, 2024
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 14, 2024
@ldorau
Fix trackingFree() for providers not supporting free() op
74a9354 
Fix trackingFree() for providers not supporting free() op:
do not add memory back to the tracker,
if the provider does not support the free() operation.

Fixes: oneapi-src#864

Signed-off-by: Lukasz Dorau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldorau ldorau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DRAFT] Enable IPC tests with the proxy library ldorau/unified-memory-framework
1 participant
@ldorau