diff --git a/.github/workflows/library.yml b/.github/workflows/library.yml index d6057597..4f4351b2 100644 --- a/.github/workflows/library.yml +++ b/.github/workflows/library.yml @@ -48,8 +48,6 @@ jobs: - name: Clean project run: ./gradlew clean --stacktrace - - name: Run unit tests with Gradle - run: ./gradlew :library:clean :library:testDebugUnitTest --stacktrace - name: Generate & upload library snapshot artifact AAR (Android Archive) file run: ./gradlew :library:clean --stacktrace && ./gradlew :library:assembleRelease --stacktrace && ./gradlew :library:publishMavenJavaPublicationToMavenCentralRepository --stacktrace diff --git a/library/build.gradle b/library/build.gradle index cd6e0d94..98e4d7b8 100644 --- a/library/build.gradle +++ b/library/build.gradle @@ -13,7 +13,7 @@ buildscript { apply plugin: 'realm-android' apply plugin: 'maven-publish' -version '0.10.6-SNAPSHOT' +version '0.10.6-2-SNAPSHOT' project.version = this.version @@ -123,7 +123,7 @@ dependencies { configuration -> //implementation (project(":utils")) { // Uncomment the line below when creating releases implementation('io.ona.kujaku:utils:0.10.6-SNAPSHOT') { - transitive = true; + transitive = true exclude group: 'com.mapbox.mapboxsdk', module: 'mapbox-android-sdk' exclude group: 'com.android.support', module: 'support-v4' } diff --git a/library/src/test/java/io/ona/kujaku/services/MapboxOfflineDownloaderServiceTest.java b/library/src/test/java/io/ona/kujaku/services/MapboxOfflineDownloaderServiceTest.java index 4d1ef513..2d0f2af6 100644 --- a/library/src/test/java/io/ona/kujaku/services/MapboxOfflineDownloaderServiceTest.java +++ b/library/src/test/java/io/ona/kujaku/services/MapboxOfflineDownloaderServiceTest.java @@ -65,11 +65,6 @@ import static org.junit.Assert.fail; import static org.mockito.Mockito.mock; -/** - * - * - * Created by Ephraim Kigamba - ekigamba@ona.io on 05/12/2017. - */ @RunWith(RobolectricTestRunner.class) @Config(manifest = Config.NONE, shadows = { @@ -83,23 +78,23 @@ }) public class MapboxOfflineDownloaderServiceTest { - private String mapName = UUID.randomUUID().toString(); + private final String mapName = UUID.randomUUID().toString(); private static final String TAG = MapboxOfflineDownloaderServiceTest.class.getSimpleName(); private Context context; private MapboxOfflineDownloaderService mapboxOfflineDownloaderService; - private String sampleValidMapboxStyleURL = "mapbox://styles/ona/90kiosdcIJ3d"; + private final String sampleValidMapboxStyleURL = "mapbox://styles/ona/90kiosdcIJ3d"; private String mapboxAccessToken; - private float minZoom = 22; - private float maxZoom = 10; - private LatLng topLeftBound = new LatLng(9.1, 9.1); - private LatLng topRightBound = new LatLng(9.1, 20.5); - private LatLng bottomRightBound = new LatLng(1.1, 20.5); - private LatLng bottomLeftBound = new LatLng(9.1, 1.1); + private final float minZoom = 22; + private final float maxZoom = 10; + private final LatLng topLeftBound = new LatLng(9.1, 9.1); + private final LatLng topRightBound = new LatLng(9.1, 20.5); + private final LatLng bottomRightBound = new LatLng(1.1, 20.5); + private final LatLng bottomLeftBound = new LatLng(9.1, 1.1); private CountDownLatch latch; - private ArrayList resultsToCheck = new ArrayList<>(); + private final ArrayList resultsToCheck = new ArrayList<>(); @Before public void setUp() throws Exception {