Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'To' address bar partially hidden #19

Open
agrycroko opened this issue Sep 22, 2015 · 7 comments
Open

'To' address bar partially hidden #19

agrycroko opened this issue Sep 22, 2015 · 7 comments

Comments

@agrycroko
Copy link

Hi @omorandi I'm using this module on an iPad running iOS8 and 9 with Ti SDK 5.0.0. When the SMS dialog appears the 'To' address bar is partially hidden below the 'New Message' navigation bar - see attached image.

Works great on an iPhone.

img_0027

@omorandi
Copy link
Owner

Hi, can you give some more details on the kind of ipad? Are you seeing this on both iOS8 and iOS9? iPad only, or also iPhone?
For instance, I couldn't reproduce this in my tests with either ios8, or 9. Moreover, the sms dialog is a system control, so I doubt we can do anything for it. In other words it looks like it could be an iOS bug.

@agrycroko
Copy link
Author

Hi, it's on an iPad Air running iOS9. Works fine on an iPhone (opens full screen), it's just an iPad issue.

So, I've got a Ti window defined as:

var myWindow = Ti.UI.createWindow({
backgroundColor: '#000000',
fullscreen: true,
tabBarHidden: true,
navBarHidden: true
});

Then later on in this window's code I call the module's .open({animated: true}) method to make it appear over the top of my window.

The gap above the SMS dialog's nav bar in my previous screen shot looks to be about the height of where the iOS status bar would go?

If you are unable to reproduce it, it may be something peculiar to my app code maybe.

Thanks,
Gary.

@agrycroko
Copy link
Author

Also in tiapp.xml I have these settings:

<fullscreen>true</fullscreen>
<navbar-hidden>true</navbar-hidden>

And these in ios plist settings:

<key>UIPrerenderedIcon</key>
<true/>
<key>UIStatusBarHidden</key>
<true/>
<key>UIStatusBarStyle</key>
<string>UIStatusBarStyleDefault</string>

@omorandi
Copy link
Owner

Ok, I've been able to reproduce this and it's an issue with the full-screen setting.
I tried some possible solutions, but without much success. Actually the sms module from Ben Bahrenburg (https://github.com/benbahrenburg/benCoding.SMS) seems to have some code in place for handling similar situations: https://github.com/benbahrenburg/benCoding.SMS/blob/master/Classes/BencodingSmsSMSDialogProxy.m#L159

It would be worth a try

@agrycroko
Copy link
Author

Hi @omorandi thanks for looking into this and good news you've managed to reproduce the problem. I did actually use the Bencoding module before trying yours, but will look at the code. If you're also able to come up with a solution please post here :) I've got a client app nearing completion that's using SMS so would be great to have it working. Regards.

@agrycroko
Copy link
Author

Didn't mention above - the Bencoding module was showing the same issue before I tried yours :)

@agrycroko
Copy link
Author

OK, when I set the fullscreen: true Ti Window property to false and then open the SMS dialog it works properly - great news.

The side-effect of doing this is the status bar appears at the top of the Ti Window, so have made this look prettier by opening a plain white Ti Window with fullscreen: false then immediately opening the SMS dialog over the top of it.

Thanks for you help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants