Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identity_url should be used for uid instead of display_identifier #36

Open
ntippie opened this issue May 31, 2019 · 0 comments
Open

identity_url should be used for uid instead of display_identifier #36

ntippie opened this issue May 31, 2019 · 0 comments

Comments

@ntippie
Copy link

ntippie commented May 31, 2019

omniauth-openid/lib/omniauth/strategies/open_id.rb

Line 69 in 8a46fa9

uid { openid_response.display_identifier }

As noted in the OpenID spec, the claimed identifier should be used (#identity_url instead of #display_identifier).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ntippie