Make LDAP bind failure cause an ldap_error, rather than an invalid_credentials #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,7 +71,9 @@ def bind_as(args = {}) | |||
| result = false | |||
| @connection.open do |me| | |||
| rs = me.search args | |||
| if rs and rs.first and dn = rs.first.dn | |||
| raise ConnectionError.new("bind failed") unless rs | |||
There was a problem hiding this comment.
Net::LDAP#search returns nil if the operation was not successful: https://github.com/ruby-ldap/ruby-net-ldap/blob/master/lib/net/ldap.rb#L722-765
Previously, this was just not entering the if and returning the default result of false. If search can successfully connect, but cannot find results (bad username/password in the params), #search returns an empty array, and we still get invalid_credentials as a result.
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51