Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonies plugin issue #123

Open
jfagan1 opened this issue Mar 10, 2024 · 0 comments
Open

Harmonies plugin issue #123

jfagan1 opened this issue Mar 10, 2024 · 0 comments

Comments

@jfagan1
Copy link

jfagan1 commented Mar 10, 2024

I think there is an issue with the harmonies plugin for specific input values. For example if I start with certain hex values sometimes the result returned is slightly off. For example:

const color = colord("#03FF84");
color.harmonies("complementary").map((c) => c.toHex()); // ["#03FF85, "#FF037D"]

You can see that the original color changes from #03FF84 to #03FF85. This problem happens on all harmonies for this color: tetradic, analogous etc. I took a quick look at the source code and I suspect some kind of rounding might be occurring. Does anyone know a way around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant