Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachment dialog not loading #499

Closed
dominikl opened this issue Aug 3, 2023 · 6 comments
Closed

Add attachment dialog not loading #499

dominikl opened this issue Aug 3, 2023 · 6 comments

Comments

@dominikl
Copy link
Member

dominikl commented Aug 3, 2023

See https://forum.image.sc/t/unable-to-add-attachment-using-omero-web/84146/ .
The number of available attachments for the logged in user is probably too long. Pagination required?

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/unable-to-add-attachment-using-omero-web/84146/20

@will-moore
Copy link
Member

will-moore commented Aug 7, 2023

To try and reproduce locally, need lots of FileAnnotations...
These don't need to be different OriginalFiles, so we can create lots by picking an existing OriginalFile and...

$ omero login

$ for i in {1..10000}; do omero obj new FileAnnotation file=OriginalFile:3070; done

Using session for will@localhost:4064. Idle timeout: 10 min. Current group: Swedlow Lab
FileAnnotation:2530
...

@will-moore
Copy link
Member

I don't know how many FileAnnotations are needed to cause the exception reported above, but I think that the user in that case is not trying to pick from E.g. 10000 existing FileAnnotations, but is just trying to upload a NEW File.

It may be that if you've got enough FileAnnotations to trigger the Ice::MemoryLimitException then the web UI might also do a bad job (or fail) to display them so you can actually pick one. It would be a shame if this broke the "Upload File" functionality. So we should probably pick a number of FileAnnotations that we know works OK, and if the user has more than that, we say "additional files not loaded".

@joshmoore
Copy link
Member

👍 with incremental improvements being:

  • stating the number of additional files (fairly straight-forward)
  • allowing paging through the additional files (probably quite a bit of work)

@chris-allan
Copy link
Member

@knabar / @will-moore: Also close with #517 and the merge and release of #519 in 5.24.0?

@will-moore
Copy link
Member

Yep - issue is fixed now, thx 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants