Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The option for cooldown reset should be based on the first entry in the sequence #38

Open
Telokis opened this issue Feb 25, 2024 · 3 comments

Comments

@Telokis
Copy link

Telokis commented Feb 25, 2024

Since the sequence will always reset to the start, it doesn't make sense to use the cooldown of anything other than the first entry.
For example, if, as a druid, I have Renewal with 90s cd and then healthstone with 60s cd, the reset condition needs to be 90 and not 60.

With this behavior, the sequence will only reset if it can be used again.

@ollidiemaus
Copy link
Owner

ollidiemaus commented Feb 25, 2024 via email

@Telokis
Copy link
Author

Telokis commented Feb 25, 2024

Yes you are right I’ll add this as soon as I find time.

@ollidiemaus Thanks for answering so quickly! I can do it myself, no problem!
From what I can see, it's inside the buildSpellMacroString() function. Is ham.spellIDs sorted so that ham.spellIDs[0] is the first element of the sequence? If so, I have enough information to do it.

@Telokis
Copy link
Author

Telokis commented Feb 25, 2024

@ollidiemaus After taking a closer look, it seems like ham.spellIDs only contains info about the user spells. I think there isn't a healthstone or healing pot in there, is that right? If so, the lowest cooldown will always be a self-healing spell which will be placed at the beginning of the sequence.
If those assumptions are right, this issue is already fixed but we need to update the wording of the config option to make it clearer what it really does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants