Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: str to bytes #28

Merged
merged 4 commits into from
Dec 23, 2023
Merged

feat: str to bytes #28

merged 4 commits into from
Dec 23, 2023

Conversation

olivmath
Copy link
Owner

@olivmath olivmath commented Dec 23, 2023

🚨 ATTENTION

I have changed the data consumption from str to bytes, which makes the final result different from everything that has been done so far.

This change will be used to implement #25 before correcting all the tests.

This change will break compatibility, let's go to v1!!! 🚀🚀🚀

@olivmath olivmath added refactor Improve code, Does not affect any features DANGER This PR will be approved/merged with some failed tests, NOT DEPLOYABLE labels Dec 23, 2023
@olivmath olivmath self-assigned this Dec 23, 2023
test/test_merkle_tree.py Dismissed Show dismissed Hide dismissed
test/test_merkle_tree.py Dismissed Show dismissed Hide dismissed
@olivmath olivmath merged commit c8392c1 into main Dec 23, 2023
11 of 12 checks passed
@olivmath olivmath deleted the feat/str-to-bytes branch December 23, 2023 03:26
@olivmath olivmath linked an issue Dec 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DANGER This PR will be approved/merged with some failed tests, NOT DEPLOYABLE refactor Improve code, Does not affect any features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong way of Hash Function is passed
1 participant