hardcoded connection limit of 32768

[ei8ht187]

We recently had a log message that more than 32768 miners are connected. It seems that this limit is hardcoded

miningcore/src/Miningcore/Stratum/StratumConnection.cs

Line 51 in b0f872f

private const int MaxInboundRequestLength = 0x8000;

Is there any reason, except limit the ressources, for this hardcoded connection limit? If not, is it possible to make this value configurable? Asking because our servers can easily handle those 32k connections.

[oliverw]

MC has no artificial connection limit. The line of code you referred to defines the maximum length of a JSON-RPC request received by a miner.

You most like likely hit an OS limit.

[ei8ht187]

Just asking because we had several error logs caused by this line

miningcore/src/Miningcore/Stratum/StratumConnection.cs

Line 265 in b0f872f

throw new InvalidDataException($"Incoming data exceeds maximum of {MaxInboundRequestLength}");

This references back to the constant variable in my first post.

Edit: Ah wait... you mean, there was someone sending answers bigger than 32k of something (bit/byte/characters)? or one miner with 32k connections from the same wallet?

[oliverw]

Just asking because we had several error logs caused by this line

miningcore/src/Miningcore/Stratum/StratumConnection.cs

Line 265 in b0f872f

throw new InvalidDataException($"Incoming data exceeds maximum of {MaxInboundRequestLength}");

This references back to the constant variable in my first post.

Edit: Ah wait... you mean, there was someone sending answers bigger than 32k of something (bit/byte/characters)? or one miner with 32k connections from the same wallet?

The former (bytes).