diff --git a/Classes/OldModel/LegacyRegistration.php b/Classes/OldModel/LegacyRegistration.php index 546dd6d5e..d4ddc4690 100644 --- a/Classes/OldModel/LegacyRegistration.php +++ b/Classes/OldModel/LegacyRegistration.php @@ -69,25 +69,8 @@ class LegacyRegistration extends AbstractModel */ protected array $checkboxes = []; - /** - * cached seminar objects with the seminar UIDs as keys and the objects as values - * - * @var array - */ - private static array $cachedSeminars = []; - protected ?FrontEndUser $user = null; - /** - * Purges our cached seminars array. - * - * This function is intended for testing purposes only. - */ - public static function purgeCachedSeminars(): void - { - self::$cachedSeminars = []; - } - /** * Gets the number of seats that are registered with this registration. * @@ -381,13 +364,7 @@ public function getSeminarObject(): LegacyEvent if (!($this->seminar instanceof LegacyEvent) && $this->isOk()) { $seminarUid = $this->getRecordPropertyInteger('seminar'); \assert($seminarUid > 0); - if (isset(self::$cachedSeminars[$seminarUid])) { - $this->seminar = self::$cachedSeminars[$seminarUid]; - } else { - $seminar = GeneralUtility::makeInstance(LegacyEvent::class, $seminarUid); - $this->seminar = $seminar; - self::$cachedSeminars[$seminarUid] = $seminar; - } + $this->seminar = GeneralUtility::makeInstance(LegacyEvent::class, $seminarUid); } return $this->seminar; diff --git a/Tests/Functional/Service/RegistrationManagerTest.php b/Tests/Functional/Service/RegistrationManagerTest.php index 40ea4a4fd..129c2cd10 100644 --- a/Tests/Functional/Service/RegistrationManagerTest.php +++ b/Tests/Functional/Service/RegistrationManagerTest.php @@ -92,7 +92,6 @@ protected function setUp(): void $this->initializeBackEndLanguage(); - LegacyRegistration::purgeCachedSeminars(); $configurationRegistry = ConfigurationRegistry::getInstance(); $this->configuration = new DummyConfiguration( [ diff --git a/Tests/LegacyFunctional/OldModel/LegacyRegistrationTest.php b/Tests/LegacyFunctional/OldModel/LegacyRegistrationTest.php index 4bc2dc3f3..8c0ab6098 100644 --- a/Tests/LegacyFunctional/OldModel/LegacyRegistrationTest.php +++ b/Tests/LegacyFunctional/OldModel/LegacyRegistrationTest.php @@ -49,8 +49,6 @@ protected function setUp(): void GeneralUtility::makeInstance(Context::class) ->setAspect('date', new DateTimeAspect(new \DateTimeImmutable('2018-04-26 12:42:23'))); - LegacyRegistration::purgeCachedSeminars(); - $this->testingFramework = new TestingFramework('tx_seminars'); $rootPageUid = $this->testingFramework->createFrontEndPage(); $this->testingFramework->changeRecord('pages', $rootPageUid, ['slug' => '/home']); @@ -514,38 +512,6 @@ public function commitToDbCanCreateNewRecord(): void ); } - // Tests regarding the cached seminars. - - /** - * @test - */ - public function purgeCachedSeminarsResultsInDifferentDataForSameSeminarUid(): void - { - $seminarUid = $this->testingFramework->createRecord( - 'tx_seminars_seminars', - ['title' => 'test title 1'] - ); - - $registrationUid = $this->testingFramework->createRecord( - 'tx_seminars_attendances', - ['seminar' => $seminarUid] - ); - - $this->testingFramework->changeRecord( - 'tx_seminars_seminars', - $seminarUid, - ['title' => 'test title 2'] - ); - - LegacyRegistration::purgeCachedSeminars(); - $subject = new LegacyRegistration($registrationUid); - - self::assertSame( - 'test title 2', - $subject->getSeminarObject()->getTitle() - ); - } - // Tests for setting and getting the user data /** diff --git a/Tests/LegacyFunctional/Service/RegistrationManagerTest.php b/Tests/LegacyFunctional/Service/RegistrationManagerTest.php index 55a29d54f..093e82f21 100644 --- a/Tests/LegacyFunctional/Service/RegistrationManagerTest.php +++ b/Tests/LegacyFunctional/Service/RegistrationManagerTest.php @@ -109,7 +109,6 @@ protected function setUp(): void $this->addMockedInstance(MailMessage::class, $this->email); $this->addMockedInstance(MailMessage::class, $secondEmail); - LegacyRegistration::purgeCachedSeminars(); $configurationRegistry = ConfigurationRegistry::getInstance(); $this->configuration = new DummyConfiguration( [