Balancer Time_Wait Issue

[Bubsavvage]

My team is using the load balancer to horizontally scale and provide processing retention for an application that does cpu intensive calculations on data. The issue we are running into is that it doesn't seem configuring transport attributes on the RoundTripper is not quite opened up for us yet, unless its intended for us to use the http.DefaultTransport. We want to change the MaxIdleConns and MaxIdleConnsPerHost to help avoid time_waits when making requests. Perhaps leaving a parameter open for us when creating the balancer to set our transport will be useful. Just a suggestion really.

[olivere]

You're correct. What about changing Transport to something like this?

type Transport struct {
  next http.RoundTripper
  b     Balancer
  ...
}

func NewTransport(b Balancer, options ...TransportOption) *Transport {
  t := &Transport{
    next: http.DefaultTransport,
    b: b,
  }
  for _, option := range options {
    option(t)
  }
  ...
}

type TransportOption func(*Transport)

func WithRoundTripper(r http.RoundTripper) TransportOption {
  return func(t *Transport) {
    t.next = r
  }
}

...

Maybe we need to change NewClient, too. Or at least provide more options to it.