-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show cursors of collaborators #80
Draft
newsch
wants to merge
15
commits into
master
Choose a base branch
from
newsch/collab-cursors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newsch
force-pushed
the
newsch/collab-cursors
branch
from
May 29, 2019 04:59
8e3eaa6
to
6af01c8
Compare
Before making more breaking changes to the networking protocol (like sending user coordinates back and forth for cursor support), it seemed best to add a method of negotiating a protocol version so things can fail or downgrade more gracefully. As implemented here, previous versions of servers and clients will not work with these updated versions. This would be a pretty big problem, except that as far as I know nobody uses this project regularly, especially in a networked/remote capacity. Because previously the client expected canvas data to be sent over immediately, the only way that I can think of to support older clients while not requiring that canvas send is to add a timeout on the server that waits for a version number and then sends the canvas if nothing is sent, which seems pretty unideal.
Cursor colors are now consistent across clients
newsch
force-pushed
the
newsch/collab-cursors
branch
from
August 29, 2020 01:10
6af01c8
to
81ac500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
TODO: