Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate upload logic #18

Open
olejnjak opened this issue Oct 22, 2021 · 1 comment
Open

Validate upload logic #18

olejnjak opened this issue Oct 22, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@olejnjak
Copy link
Owner

Currently when running upload command, Torino goes through Carthage/Build folder and searches for .<dependency>.version files. For all found version files it then archives version file and its binary and uploads it.

Not sure if this is correct - another approach might be to parse Cartfile.resolved first, then check respective version files and after that create archive with binary and version file, that gets uploaded.

Currently there definitely seems to be an issue when version file of framework without XCFramework is present (version file doesn't contain container attribute), it gets archived and uploaded. This archive contains only a version file, without binary. This definitely needs to be fixed.

@olejnjak olejnjak self-assigned this Oct 22, 2021
@olejnjak
Copy link
Owner Author

Decided that correct approach would be to parse Cartfile.resolved, locate relevant version files and then upload dependencies, that have available XCFramework.

@olejnjak olejnjak added the bug Something isn't working label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant