Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update new ClientOpt from 5509e40 with origin #31

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: update new ClientOpt from 5509e40 with origin #31

merged 1 commit into from
Nov 13, 2023

Conversation

jpf-okteto
Copy link

This PR updates withCredentialsAndSystemRoots ClientOpt introduced for v0.11.6-okteto branch at 6f351ec (cherry-picked from 5509e40) with upstream withCredentials ClientOpt. It should match the generic part of the following snippets:

It fixes a bug where address hostname given to the New client function didn't match servername given to the ClientOpt.

Part of https://okteto.atlassian.net/browse/RAIN-64

@jpf-okteto jpf-okteto added the bug Something isn't working label Nov 10, 2023
@jpf-okteto jpf-okteto self-assigned this Nov 10, 2023
@jpf-okteto jpf-okteto merged commit 721336d into v0.11.6-okteto Nov 13, 2023
14 of 40 checks passed
@jpf-okteto jpf-okteto deleted the jpf-okteto/rain-64/v0-11-6-patch branch November 13, 2023 10:12
jpf-okteto added a commit that referenced this pull request Feb 18, 2024
@jpf-okteto
chore: add WithCAAndSystemRoot client opt (PLAT-351)
8aaa190 
This commits adds a new client opt which mixes WithServerConfigSystem and WithCAAndSystemRoot.

It replaces the following commits/PRs added in v0.11.6:
- 721336d / #31
- 3981d65 / #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol approved these changes

@maroshii maroshii Awaiting requested review from maroshii

Assignees

@jpf-okteto jpf-okteto

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpf-okteto @ifbyol