Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rofi-power's OPTIONS configuration #2

Open
orestisfl opened this issue May 10, 2017 · 3 comments
Open

Improve rofi-power's OPTIONS configuration #2

orestisfl opened this issue May 10, 2017 · 3 comments

Comments

@orestisfl
Copy link

Some time ago I copied the rofi-power script and made some modifications in the way it handles options: https://github.com/orestisf1993/dotfiles/blob/d94285bb77d7ff3e0fc69c66f8a1b04b7ed79df6/binaries/bin/i3-rofi-actions

It uses an associative array to store the options and a normal array to store the order. This way you can just do add_option "Exit" "i3-msg exit" to provide an "exit" option. The user can store his options in a script in $HOME/.config/rofi-power/ filled with add_option lines.

I can create a pull request if you are interested.

@dennisschuerholz
Copy link

I reworked "parts" of rofi-power a few months ago to address some issue with default configuration options and to add some functionality with my PR #1
@okraits never came back on this topic though, so it seems he doesn't work on this project anymore

@okraits
Copy link
Owner

okraits commented Sep 11, 2017

Sorry for being inactive for such a long time. I will try to have a look at both of your proposals in the near future.

@okraits
Copy link
Owner

okraits commented Dec 31, 2017

Will look into this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants