Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to care config #8470

Open
3 tasks
rithviknishad opened this issue Sep 3, 2024 · 4 comments · May be fixed by #9032
Open
3 tasks

Enhancements to care config #8470

rithviknishad opened this issue Sep 3, 2024 · 4 comments · May be fixed by #9032
Assignees
@Alokih
Labels
good first issue Good for newcomers hacktoberfest stale work-in-progress

Comments

@rithviknishad
Copy link
Member

#8445 Introduces care.config.ts for making CARE configurable from ENVs. However there are couple of enhancements that can be done:

  • Perform config validation during vite build so that build fails thus preventing exceptions from being thrown during runtime if any.
  • Sentry config to be optional and enable sentry only if configured.
  • Plausible config to be optional and enable plausible only if configured.
@rithviknishad rithviknishad added the waiting for related PR a co-related detail PR is under construction label Sep 3, 2024
@rithviknishad rithviknishad mentioned this issue Sep 3, 2024
Merged
6 tasks
@rithviknishad rithviknishad removed the waiting for related PR a co-related detail PR is under construction label Sep 3, 2024
@github-actions github-actions bot added the stale label Sep 18, 2024
@bodhish bodhish added good first issue Good for newcomers and removed stale labels Sep 18, 2024
@Deexit1
Copy link

Deexit1 commented Oct 2, 2024 •
edited
Loading

@bodhish / @rithviknishad I will be able to complete the 2nd and 3rd task e.g., optional plugins based on provided config.

Need Clarification:
For the first task, which kind of config validations are required for each config option ? Also, should we use any schema validation libraries like zod ?

@bodhish bodhish mentioned this issue Oct 3, 2024
Merged
6 tasks
Sulochan-khadka added a commit to Sulochan-khadka/care_fe that referenced this issue Oct 6, 2024
@Sulochan-khadka
Enhancements to care config ohcnetwork#8470
84bfb36
@Sulochan-khadka Sulochan-khadka mentioned this issue Oct 6, 2024
Closed
6 tasks
@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Oct 15, 2024 •
edited
Loading

Vite's community plugins includes two env validation plugins, one of which supports Yup/Zod etc. So, we could make use of that, or build one ourselves.

@github-actions github-actions bot added the stale label Oct 30, 2024
@Alokih
Copy link

Alokih commented Nov 6, 2024

@Jacobjeevan , @rithviknishad can I work on this issue ?

@Alokih Alokih linked a pull request Nov 6, 2024 that will close this issue
Open
6 tasks
@Alokih
Copy link

Alokih commented Nov 6, 2024

@Jacobjeevan sir, I have created a PR can you review it once , I have just added validation for only 5 env , should I add more ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alokih Alokih

Labels
good first issue Good for newcomers hacktoberfest stale work-in-progress
Projects
Care
Status: In Progress
Milestone
No milestone
5 participants
@bodhish @rithviknishad @Jacobjeevan @Deexit1 @Alokih