Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Subscription Error Handling and Unsubscribe Message Mismatch #9021

Open
Mahendar0701 opened this issue Nov 6, 2024 · 1 comment · May be fixed by #9038
Open

Notification Subscription Error Handling and Unsubscribe Message Mismatch #9021

Mahendar0701 opened this issue Nov 6, 2024 · 1 comment · May be fixed by #9038
Assignees

Comments

@Mahendar0701
Copy link
Contributor

Mahendar0701 commented Nov 6, 2024

Describe the bug
In the notification section, when the Subscribe button is clicked, the site requests user permission. If the user closes the permission prompt by clicking 'X', an error message stating "permission denied" should be displayed. Currently, instead of showing this error, the subscribe button continues to load indefinitely, even after the API rejection response is received. Additionally, when the Unsubscribe button is clicked, the notification message displayed is not relevant to the action.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Notifications'
  2. Click on 'Subscribe'
  3. Close the permission prompt by clicking the 'X' button.
  4. Observe that the error message "permission denied" is not displayed; instead, the subscribe button continues to load.
  5. Click on Unsubscribe and notice that the notification message displayed is not relevant.

Expected behavior

  1. When the permission prompt is closed by the user, an error message saying "permission denied" should be shown.
  2. The Subscribe button should stop loading once the API rejection response is received.
  3. When Unsubscribe is clicked, an appropriate and relevant notification message should be displayed.

Screenshots

Subscribe issue
Image

Image

Irrelevant Notification Message on clicking unsubscribe:
Image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Mahendar0701
Copy link
Contributor Author

@rithviknishad @nihal467 i want to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Up Next
Development

Successfully merging a pull request may close this issue.

1 participant