Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clear and cancel button in the preset pop-up of asset camera configuration page #8902

Closed
2 tasks
nihal467 opened this issue Oct 23, 2024 · 5 comments · Fixed by #8921
Closed
2 tasks
Assignees
Labels

Comments

@nihal467
Copy link
Member

Describe the bug

When trying to clear or close the pop-up on the camera asset configuration page, there is no clear or cancel option available, causing confusion for users.

To Reproduce
Steps to reproduce the behavior:

  1. Go to asset tab
  2. Click on any camera asset card
  3. click on configuration and try to create a preset
  4. See error

Expected behavior

  • Add a Cancel button adjacent to the Submit button for closing the pop-up.
  • Add a Clear button within the preset input field to clear the input value.

Note: Ensure these changes align with the existing design language for consistency.

Screenshots

Image

@rithviknishad rithviknishad added the good first issue Good for newcomers label Oct 23, 2024
@Rishith25
Copy link
Contributor

Rishith25 commented Oct 23, 2024

@nihal467 Can I work on this? Please assign it me.

@JavidSumra
Copy link
Contributor

Hey Nihal can you please assign it to me?

@Rishith25
Copy link
Contributor

Rishith25 commented Oct 24, 2024

Hi @nihal467 I logged in as a district admin and attempted to add a preset, but I'm encountering an issue where it shows "unable to get position." Could you please guide me on how to add a preset and open the popup for the camera asset and how to reproduce the behavior you’re demonstrating.

Image

@nihal467
Copy link
Member Author

you need to configure the camera first for that, to get the camera configuration detail, look for asset named dev camera , use the same configuration for your asset

@Rishith25
Copy link
Contributor

@nihal467 I logged in as district admin. I think the dev camera is deleted hence i can not find it. Can you share the camera configuration details.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants