New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New appliance support: Fridge, Hub, Hood #141

Open

JanezKr wants to merge 16 commits into ofalvai:main from JanezKr:main

JanezKr commented Jul 3, 2022

Different program options on Oven
New appliances support:
- Fridge
- Hub
- Hood (experimental)

JanezKr added 8 commits

July 3, 2022 23:50


          New appliance support: Fridge, Hub, Hood

e198e4c

 - Different program options on Oven
 - New appliances support:
     - Fridge
     - Hub
     - Hood (experimental)


          Update model.py

6d8e32d

bugfixes


          new sensors

d85cda8

new sensors


          Oven remaining time

2f2def2


          Oven remaining time rev

6c04664


          Update model.py

0aa1773


          home assistant varsion 2022.11

0b81731


          Merge branch 'main' into main

9ed37e6

Author

JanezKr commented Nov 18, 2022

Please Olivér, can you merge my code too. I add few new appliances in last months.

Tanks in advance,

Janez

ofalvai reviewed

View reviewed changes

custom_components/candy/client/__init__.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/client/model.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/config_flow.py Outdated Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/binary_sensor.py Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/binary_sensor.py Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/binary_sensor.py Show resolved Hide resolved

ofalvai reviewed

View reviewed changes

custom_components/candy/binary_sensor.py Show resolved Hide resolved

Owner

ofalvai commented Nov 19, 2022

Thank you @JanezKr for the contribution and apologies for the long delay from me.

I had a quick look at the PR and added a few comments about the various new appliances and features, please take a look.

A few general comments:

Please revert the changes that wrap long lines and add extra empty lines here and there. It makes really hard to review this PR, and I don't enforce a maximum line length, please don't wrap existing lines into multiple lines.
The tests are failing, please take a look at the CI run

JanezKr added 5 commits

November 19, 2022 14:11


          temp_set

bad9931

change property from  temSet into temp_set


          FridgeStatus, Hood object change

8018ea1

Some fixes on Fridge and Hood.


          renamed grease_filter into grease_filter_clean_needed and carbon_filt…

dc015aa

…er into carbon_filter_clean_needed

renamed grease_filter into grease_filter_clean_needed  and carbon_filter into carbon_filter_clean_needed


          fan = fan_level

b5d788c


          resp.json some fixes

1e18312

JanezKr added 3 commits

November 19, 2022 15:39


          commented option CONF_KEY_USE_ENCRYPTION

7e92042


          commented CONF_KEY_USE_ENCRYPTION

8b7e5de


          Merge branch 'ofalvai:main' into main

a185042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet