Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comparing c-type string by their addresses is a bad idea #31

Open
eyeco opened this issue Dec 15, 2015 · 1 comment
Open

comparing c-type string by their addresses is a bad idea #31

eyeco opened this issue Dec 15, 2015 · 1 comment

Comments

@eyeco
Copy link

eyeco commented Dec 15, 2015

when comparing c-type strings in videoInput::getDeviceIDFromName (videoInput.cpp, line 808) you should use strcmp, not operator ==
wingedrobin added a commit to wingedrobin/videoInput that referenced this issue Feb 28, 2016
@wingedrobin
Fixed issue ofTheo#31
6b064ac 
1. Use strcmp to replace operator ==.
2. Fixed line 821. Declare name as pointer to "const" char.
mkalten added a commit to mkalten/videoInput that referenced this issue May 1, 2016
@mkalten
Merge pull request #1 from wingedrobin/master
d05ca3b 
Fixed issue ofTheo#31
@MIvanchev
Copy link

MIvanchev commented Nov 12, 2017 •
edited
Loading

This issue is a clone of #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyeco @MIvanchev