Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default value for dissipative to None #563

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Change default value for dissipative to None #563

merged 3 commits into from
Oct 27, 2024

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Oct 27, 2024 •
edited
Loading

Resolve #463
Resolve #540

@pep8speaks
Copy link

pep8speaks commented Oct 27, 2024 •
edited
Loading

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 558:80: E501 line too long (80 > 79 characters)
Line 638:80: E501 line too long (80 > 79 characters)

Comment last updated at 2024-10-27 20:26:47 UTC

@fwitte fwitte merged commit b836623 into dev Oct 27, 2024
5 of 7 checks passed
@fwitte fwitte deleted the feature/make-dissipative-mandatory-keyword-for-exergy-analysis branch October 27, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fwitte @pep8speaks