Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorption features to TESPy #443

Open
wants to merge 23 commits into
base: dev
Choose a base branch
from
Open

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Nov 5, 2023

This PR will add equations to the fluid property back-end with the aim to model absorption and desorption processes, e.g. in sorption heat pumps or refrigeration applications. The initial drafts can be found in the root directory of the repository (test_absorber.py and test_desorber.py). The context is based on the examples at https://github.com/LudwigIrrgang/SorpPump.

@pep8speaks
Copy link

pep8speaks commented Nov 5, 2023

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 355:80: E501 line too long (83 > 79 characters)

Line 724:80: E501 line too long (106 > 79 characters)
Line 745:80: E501 line too long (117 > 79 characters)
Line 753:80: E501 line too long (128 > 79 characters)
Line 757:80: E501 line too long (128 > 79 characters)
Line 761:80: E501 line too long (108 > 79 characters)
Line 776:80: E501 line too long (128 > 79 characters)
Line 780:80: E501 line too long (128 > 79 characters)
Line 785:80: E501 line too long (127 > 79 characters)
Line 790:80: E501 line too long (129 > 79 characters)
Line 797:80: E501 line too long (121 > 79 characters)
Line 893:80: E501 line too long (132 > 79 characters)
Line 912:80: E501 line too long (118 > 79 characters)
Line 919:80: E501 line too long (83 > 79 characters)
Line 921:80: E501 line too long (85 > 79 characters)
Line 1031:80: E501 line too long (101 > 79 characters)
Line 1032:80: E501 line too long (101 > 79 characters)

Line 727:80: E501 line too long (81 > 79 characters)
Line 928:80: E501 line too long (80 > 79 characters)
Line 1777:80: E501 line too long (116 > 79 characters)

Line 37:80: E501 line too long (95 > 79 characters)
Line 103:80: E501 line too long (84 > 79 characters)
Line 104:80: E501 line too long (87 > 79 characters)
Line 110:80: E501 line too long (84 > 79 characters)
Line 111:80: E501 line too long (87 > 79 characters)
Line 115:80: E501 line too long (83 > 79 characters)
Line 118:80: E501 line too long (80 > 79 characters)
Line 120:80: E501 line too long (83 > 79 characters)
Line 189:26: E203 whitespace before ','
Line 194:1: E303 too many blank lines (3)
Line 221:26: E203 whitespace before ','

Line 67:80: E501 line too long (103 > 79 characters)
Line 79:40: E203 whitespace before ','

Line 130:80: E501 line too long (80 > 79 characters)
Line 191:80: E501 line too long (80 > 79 characters)
Line 253:80: E501 line too long (84 > 79 characters)

Line 446:80: E501 line too long (83 > 79 characters)
Line 447:80: E501 line too long (105 > 79 characters)

Comment last updated at 2024-02-15 16:21:22 UTC

@fwitte
Copy link
Member Author

fwitte commented Aug 20, 2024

An example can be found here currently: https://github.com/fwitte/tespy-sorption-models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants