Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different results when running simulation with ES from oemof.network instead of oemof.solph #104

Open
henhuy opened this issue May 24, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@henhuy
Copy link
Collaborator

henhuy commented May 24, 2023

This issue is for all other, which might run into same bug, which cost me days to debug!

I accidentally used EnergySystem from oemof.networkenergy_system to run simulation with oemof.tabular, which gave me similar but different results than using EnergySystem from oemof.solph (as EnergySystem from oemof.solph internally adds some groupings, which ES from network does not).
This behavior is quite difficult to track down, as both EnergySystem work with oemof.tabular!

@henhuy henhuy added the bug Something isn't working label May 24, 2023
@henhuy henhuy self-assigned this May 24, 2023
@nailend
Copy link
Collaborator

nailend commented Nov 9, 2023

Indeed EnergySystem fromoemof.network.energy_system is used in tabular in general (see here) .... actually the implemented multi-period therefore should not work at all with tabular as oemof.network.energy_system.EnergySystem doesn't have the feature. Same for:

  • infer_last_interval
  • tsam (to be integrated)

I think we might have to switch so solph.EnergySystem

@nailend
Copy link
Collaborator

nailend commented Nov 9, 2023

I got it wrong. As long as we use EnergySystem from oemof.solph its fine. I totaly get why you said, it's difficult to track down.

@henhuy
Copy link
Collaborator Author

henhuy commented Nov 10, 2023

We are fine - the issue was just intended to give people a hint, if they are encountering similar problems...
I will close

@henhuy henhuy closed this as completed Nov 10, 2023
@nailend nailend reopened this Nov 28, 2023
@nailend
Copy link
Collaborator

nailend commented Nov 28, 2023

Stumbled over it again. Lets discuss this soon.
This implicityly works as long as we import from solph. Not sure if we should leave it like this here as its super confusing.
@FelixMau and me struggled with it after importing EnergySystem from oemof.tabular.datapackage which uses oemof.network version and therefore does not support multi-period etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants