Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cellular model stub #1078

Closed
p-snft opened this issue Jun 10, 2024 · 2 comments · Fixed by #1082
Closed

Remove cellular model stub #1078

p-snft opened this issue Jun 10, 2024 · 2 comments · Fixed by #1082

Comments

@p-snft
Copy link
Member

p-snft commented Jun 10, 2024

We have an experimental stub for cellular energy system modelling that in my opinion should be replaced by proper filtering of nodes and the labeling system. I suggest removing that stub. Are there objections?

@p-snft
Copy link
Member Author

p-snft commented Jun 11, 2024

@lensum, as you originally added this, I am looking forward for your feedback.

@lensum
Copy link
Contributor

lensum commented Jun 12, 2024

Seeing that this has probably caused more confusion than it brought benefits, I support this motion.

Unfortunately, I'm hard pressed for time right now, so I might not be able to help much with the removal. From the code-perspective, I think this is mostly the removal of two or three loops in the Model (or BaseModel) class.

@p-snft p-snft self-assigned this Jun 12, 2024
@p-snft p-snft linked a pull request Jun 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants